added logic for the v2 webhooks including srv lookup and hashing #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurafortino
commented
Dec 11, 2024
internal/sink/sink.go
Outdated
| if err != nil { | ||
| v2.logger.Error("error received looking up service records", zap.Error(err)) | ||
| } | ||
| dialer.NewClient() |
There was a problem hiding this comment.
do we want to create the client here? or does it make more sense to move to the send() function?
There was a problem hiding this comment.
Here is good, I think I'll push up some updates to help you with the structure. (I'll slack you)
denopink
reviewed
Dec 11, 2024
denopink
added a commit
that referenced
this pull request
Dec 16, 2024
denopink
added a commit
that referenced
this pull request
Dec 16, 2024
denopink
added a commit
that referenced
this pull request
Dec 16, 2024
…hook-v2-branch chore: feedback for @maurafortino 's #587 PR
retryhttp client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Included:
custom dialeranddial contextfunc for using the SRVs returned in newlookupfunction